Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UICollectionView/UITableView swizzle bug #316

Merged
merged 6 commits into from
May 7, 2024
Merged

fix: UICollectionView/UITableView swizzle bug #316

merged 6 commits into from
May 7, 2024

Conversation

YoloMao
Copy link
Collaborator

@YoloMao YoloMao commented May 6, 2024 •
edited
Loading

  • 修复 UICollectionView/UITableView 的点击无埋点在特殊场景下失效：比如，在 didSelect 方法中同时调用了 reloadData
  • 修复部分编译时警告
  • 升级 KeyChain 访问相关的代码，主要影响 DeviceId 持久化

@YoloMao YoloMao force-pushed the fix/list_swizzle branch from c610de3 to cfc637a Compare May 7, 2024 07:11
@growingio growingio deleted a comment from codecov bot May 7, 2024
@growingio growingio deleted a comment from sonarqubecloud bot May 7, 2024
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 83.71%. Comparing base (af66457) to head (82ade0d).

❗ Current head 82ade0d differs from pull request most recent head f5aaf04. Consider uploading reports for the commit f5aaf04 to get more accurate results

Files Patch % Lines
GrowingTrackerCore/Utils/GrowingKeyChainWrapper.m 57.14% 9 Missing ⚠️
...ackerCore/Network/GrowingNetworkInterfaceManager.m 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   82.85%   83.71%   +0.86%     
==========================================
  Files         137      137              
  Lines       10112     8064    -2048     
==========================================
- Hits         8378     6751    -1627     
+ Misses       1734     1313     -421

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
55.2% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@YoloMao YoloMao merged commit 0ec1ab0 into master May 7, 2024
4 of 13 checks passed
@YoloMao YoloMao deleted the fix/list_swizzle branch May 7, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianhui12 tianhui12 tianhui12 approved these changes

@styluo styluo styluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YoloMao @styluo @tianhui12 @GIOSDK